7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed incorrect warning for foo=$3

This commit is contained in:
Vidar Holen 2012-11-17 10:53:39 -08:00
parent ecccc7a6b7
commit 090b94161d
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ShellCheck/Analytics.hs
View File

@ -157,6 +157,7 @@ prop_checkMissingPositionalQuotes = verifyFull checkMissingPositionalQuotes "rm
prop_checkMissingPositionalQuotes2 = verifyFull checkMissingPositionalQuotes "rm ${10//foo/bar}" prop_checkMissingPositionalQuotes2 = verifyFull checkMissingPositionalQuotes "rm ${10//foo/bar}"
prop_checkMissingPositionalQuotes3 = verifyNotFull checkMissingPositionalQuotes "(( $1 + 3 ))" prop_checkMissingPositionalQuotes3 = verifyNotFull checkMissingPositionalQuotes "(( $1 + 3 ))"
prop_checkMissingPositionalQuotes4 = verifyNotFull checkMissingPositionalQuotes "if [[ $2 -gt 14 ]]; then true; fi" prop_checkMissingPositionalQuotes4 = verifyNotFull checkMissingPositionalQuotes "if [[ $2 -gt 14 ]]; then true; fi"
prop_checkMissingPositionalQuotes5 = verifyNotFull checkMissingPositionalQuotes "foo=$3 env"
checkMissingPositionalQuotes t m = checkMissingPositionalQuotes t m =
runBasicAnalysis cq t m runBasicAnalysis cq t m
where where
@ -337,6 +338,7 @@ inUnquotableContext tree t =
TA_Binary _ _ _ _ -> True TA_Binary _ _ _ _ -> True
TA_Trinary _ _ _ _ -> True TA_Trinary _ _ _ _ -> True
TA_Expansion _ _ -> True TA_Expansion _ _ -> True
T_Assignment _ _ _ -> True
T_Redirecting _ _ _ -> False T_Redirecting _ _ _ -> False
x -> case Map.lookup (getId x) tree of x -> case Map.lookup (getId x) tree of
Nothing -> False Nothing -> False