From 08aab3c16148dc4e5ca7a136b2514dd1fb95fa45 Mon Sep 17 00:00:00 2001 From: Vanessa McHale Date: Mon, 2 Apr 2018 11:48:21 -0500 Subject: [PATCH] hlints --- src/ShellCheck/AnalyzerLib.hs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/ShellCheck/AnalyzerLib.hs b/src/ShellCheck/AnalyzerLib.hs index 72e837e..d59cef0 100644 --- a/src/ShellCheck/AnalyzerLib.hs +++ b/src/ShellCheck/AnalyzerLib.hs @@ -466,7 +466,7 @@ getModifiedVariables t = _ -> Nothing guard . not . null $ str - return (t, token, str, DataString $ SourceChecked) + return (t, token, str, DataString SourceChecked) T_DollarBraced _ l -> maybeToList $ do let string = bracedString t @@ -691,9 +691,8 @@ isCommand token str = isCommandMatch token (\cmd -> cmd == str || ('/' : str) ` -- Compare a command to a literal. Like above, but checks full path. isUnqualifiedCommand token str = isCommandMatch token (== str) -isCommandMatch token matcher = fromMaybe False $ do - cmd <- getCommandName token - return $ matcher cmd +isCommandMatch token matcher = fromMaybe False $ + fmap matcher (getCommandName token) -- Does this regex look like it was intended as a glob? -- True: *foo*