From 02efc2e945e26e8c1a4a9d3f4a05e706bd278208 Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Wed, 23 Jan 2013 17:18:18 -0800 Subject: [PATCH] The test cases are fun, but not up to date. The unit tests are better. --- badcase/alphaltnum | 1 - badcase/ampersemi | 1 - badcase/apostrophecked | 1 - badcase/badKnR | 3 --- badcase/badescape | 1 - badcase/badindenting | 7 ------- badcase/dollarassign | 1 - badcase/forindollarstar | 1 - badcase/forinls | 1 - badcase/heredoccasefault | 3 --- badcase/heredoclinefault | 2 -- badcase/intosame | 1 - badcase/largepositionals | 1 - badcase/lolbackticks | 1 - badcase/lonelydollar | 1 - badcase/missingspacetest | 1 - badcase/missingspacetest2 | 1 - badcase/mvmp3s | 4 ---- badcase/mvmp3sfixed | 5 ----- badcase/poormansif | 2 -- badcase/semicolonthen | 1 - badcase/singlebracketcompare | 1 - badcase/spaceassign1 | 1 - badcase/spaceassign2 | 1 - badcase/spaceassign3 | 1 - badcase/stillapostrophecked | 1 - badcase/subshellvar | 2 -- badcase/subshellvar2 | 7 ------- badcase/subshellvar3 | 3 --- badcase/subshellvar4 | 3 --- badcase/superfluousfunction | 1 - badcase/twogreaterandone | 1 - badcase/unexpanded | 2 -- badcase/unquoteddoubleat | 1 - badcase/unquotedexpansion | 1 - badcase/unquotedtest | 1 - badcase/uuoc | 1 - badcase/worseindenting | 6 ------ goodcase/double | 2 -- goodcase/double2 | 1 - goodcase/forargs | 1 - goodcase/forloop | 1 - goodcase/fornoin | 1 - goodcase/heredoc | 3 --- goodcase/if | 1 - goodcase/ifcommand | 4 ---- goodcase/iftest | 1 - goodcase/redir | 1 - goodcase/redir2 | 1 - goodcase/redir3 | 1 - goodcase/simple | 1 - goodcase/subshellvar | 3 --- 52 files changed, 96 deletions(-) delete mode 100644 badcase/alphaltnum delete mode 100644 badcase/ampersemi delete mode 100644 badcase/apostrophecked delete mode 100644 badcase/badKnR delete mode 100644 badcase/badescape delete mode 100644 badcase/badindenting delete mode 100644 badcase/dollarassign delete mode 100644 badcase/forindollarstar delete mode 100644 badcase/forinls delete mode 100644 badcase/heredoccasefault delete mode 100644 badcase/heredoclinefault delete mode 100644 badcase/intosame delete mode 100644 badcase/largepositionals delete mode 100644 badcase/lolbackticks delete mode 100644 badcase/lonelydollar delete mode 100644 badcase/missingspacetest delete mode 100644 badcase/missingspacetest2 delete mode 100644 badcase/mvmp3s delete mode 100644 badcase/mvmp3sfixed delete mode 100644 badcase/poormansif delete mode 100644 badcase/semicolonthen delete mode 100644 badcase/singlebracketcompare delete mode 100644 badcase/spaceassign1 delete mode 100644 badcase/spaceassign2 delete mode 100644 badcase/spaceassign3 delete mode 100644 badcase/stillapostrophecked delete mode 100644 badcase/subshellvar delete mode 100644 badcase/subshellvar2 delete mode 100644 badcase/subshellvar3 delete mode 100644 badcase/subshellvar4 delete mode 100644 badcase/superfluousfunction delete mode 100644 badcase/twogreaterandone delete mode 100644 badcase/unexpanded delete mode 100644 badcase/unquoteddoubleat delete mode 100644 badcase/unquotedexpansion delete mode 100644 badcase/unquotedtest delete mode 100644 badcase/uuoc delete mode 100644 badcase/worseindenting delete mode 100644 goodcase/double delete mode 100644 goodcase/double2 delete mode 100644 goodcase/forargs delete mode 100644 goodcase/forloop delete mode 100644 goodcase/fornoin delete mode 100644 goodcase/heredoc delete mode 100644 goodcase/if delete mode 100644 goodcase/ifcommand delete mode 100644 goodcase/iftest delete mode 100644 goodcase/redir delete mode 100644 goodcase/redir2 delete mode 100644 goodcase/redir3 delete mode 100644 goodcase/simple delete mode 100644 goodcase/subshellvar diff --git a/badcase/alphaltnum b/badcase/alphaltnum deleted file mode 100644 index 4ca02d1..0000000 --- a/badcase/alphaltnum +++ /dev/null @@ -1 +0,0 @@ -if [[ $V < 3 ]]; then echo foo; fi diff --git a/badcase/ampersemi b/badcase/ampersemi deleted file mode 100644 index f8a2a4c..0000000 --- a/badcase/ampersemi +++ /dev/null @@ -1 +0,0 @@ -wget url &; echo "It's backgrounded." diff --git a/badcase/apostrophecked b/badcase/apostrophecked deleted file mode 100644 index 5649626..0000000 --- a/badcase/apostrophecked +++ /dev/null @@ -1 +0,0 @@ -echo 'Shpell... It's the best!' diff --git a/badcase/badKnR b/badcase/badKnR deleted file mode 100644 index c975dc5..0000000 --- a/badcase/badKnR +++ /dev/null @@ -1,3 +0,0 @@ -for f in * do - echo "$f" -done diff --git a/badcase/badescape b/badcase/badescape deleted file mode 100644 index 86c0c21..0000000 --- a/badcase/badescape +++ /dev/null @@ -1 +0,0 @@ -echo hello\nword diff --git a/badcase/badindenting b/badcase/badindenting deleted file mode 100644 index cd3bdd1..0000000 --- a/badcase/badindenting +++ /dev/null @@ -1,7 +0,0 @@ -# Caution, white space sensitive file! -if true -then - cat <<- FOO - Some text - FOO -fi diff --git a/badcase/dollarassign b/badcase/dollarassign deleted file mode 100644 index 2988532..0000000 --- a/badcase/dollarassign +++ /dev/null @@ -1 +0,0 @@ -$FOO=3 diff --git a/badcase/forindollarstar b/badcase/forindollarstar deleted file mode 100644 index a030e08..0000000 --- a/badcase/forindollarstar +++ /dev/null @@ -1 +0,0 @@ -for f in $*; do echo "$f"; done diff --git a/badcase/forinls b/badcase/forinls deleted file mode 100644 index c3b44e6..0000000 --- a/badcase/forinls +++ /dev/null @@ -1 +0,0 @@ -for f in $(ls *.jpg); do echo "$f"; done diff --git a/badcase/heredoccasefault b/badcase/heredoccasefault deleted file mode 100644 index a365458..0000000 --- a/badcase/heredoccasefault +++ /dev/null @@ -1,3 +0,0 @@ -cat << EOF -Hello world -Eof diff --git a/badcase/heredoclinefault b/badcase/heredoclinefault deleted file mode 100644 index e4838c9..0000000 --- a/badcase/heredoclinefault +++ /dev/null @@ -1,2 +0,0 @@ -cat << EOF -Hello world EOF diff --git a/badcase/intosame b/badcase/intosame deleted file mode 100644 index 2aa8956..0000000 --- a/badcase/intosame +++ /dev/null @@ -1 +0,0 @@ -sed 's/foo/bar/g' myfile > myfile diff --git a/badcase/largepositionals b/badcase/largepositionals deleted file mode 100644 index fe69c8f..0000000 --- a/badcase/largepositionals +++ /dev/null @@ -1 +0,0 @@ -ls ... "$9" "$10" # DOS 4ever diff --git a/badcase/lolbackticks b/badcase/lolbackticks deleted file mode 100644 index f62bc71..0000000 --- a/badcase/lolbackticks +++ /dev/null @@ -1 +0,0 @@ -echo `ls` diff --git a/badcase/lonelydollar b/badcase/lonelydollar deleted file mode 100644 index 71d5b6b..0000000 --- a/badcase/lonelydollar +++ /dev/null @@ -1 +0,0 @@ -echo "$ is special now?" diff --git a/badcase/missingspacetest b/badcase/missingspacetest deleted file mode 100644 index 9c2882c..0000000 --- a/badcase/missingspacetest +++ /dev/null @@ -1 +0,0 @@ -if [[foo ]]; then echo lol; fi diff --git a/badcase/missingspacetest2 b/badcase/missingspacetest2 deleted file mode 100644 index 1800fbc..0000000 --- a/badcase/missingspacetest2 +++ /dev/null @@ -1 +0,0 @@ -if [[ foo]]; then echo lol; fi diff --git a/badcase/mvmp3s b/badcase/mvmp3s deleted file mode 100644 index 9569880..0000000 --- a/badcase/mvmp3s +++ /dev/null @@ -1,4 +0,0 @@ -for f in *.mp3 -do - mv $f /music -done diff --git a/badcase/mvmp3sfixed b/badcase/mvmp3sfixed deleted file mode 100644 index d8f52f9..0000000 --- a/badcase/mvmp3sfixed +++ /dev/null @@ -1,5 +0,0 @@ -# There, I fixed it! -for f in "$(ls *.mp3)" -do - mv "$f" /music -done diff --git a/badcase/poormansif b/badcase/poormansif deleted file mode 100644 index 1dae836..0000000 --- a/badcase/poormansif +++ /dev/null @@ -1,2 +0,0 @@ -# When the network goes down, the backup gets deleted -[[ ! -z backup ]] && scp backup host: || rm backup diff --git a/badcase/semicolonthen b/badcase/semicolonthen deleted file mode 100644 index ebd5897..0000000 --- a/badcase/semicolonthen +++ /dev/null @@ -1 +0,0 @@ -if [[ foo ]]; then; echo lol; fi diff --git a/badcase/singlebracketcompare b/badcase/singlebracketcompare deleted file mode 100644 index 7f98c9c..0000000 --- a/badcase/singlebracketcompare +++ /dev/null @@ -1 +0,0 @@ -until [ $var > $foo ]; do var=$(cow); done diff --git a/badcase/spaceassign1 b/badcase/spaceassign1 deleted file mode 100644 index 6da7c23..0000000 --- a/badcase/spaceassign1 +++ /dev/null @@ -1 +0,0 @@ -LOL = 3 diff --git a/badcase/spaceassign2 b/badcase/spaceassign2 deleted file mode 100644 index 9a75723..0000000 --- a/badcase/spaceassign2 +++ /dev/null @@ -1 +0,0 @@ -LOL= 3 diff --git a/badcase/spaceassign3 b/badcase/spaceassign3 deleted file mode 100644 index 78869f8..0000000 --- a/badcase/spaceassign3 +++ /dev/null @@ -1 +0,0 @@ -LOL =3 diff --git a/badcase/stillapostrophecked b/badcase/stillapostrophecked deleted file mode 100644 index f8c27d6..0000000 --- a/badcase/stillapostrophecked +++ /dev/null @@ -1 +0,0 @@ -echo 'Shpell... It\'s the best!' diff --git a/badcase/subshellvar b/badcase/subshellvar deleted file mode 100644 index 986127b..0000000 --- a/badcase/subshellvar +++ /dev/null @@ -1,2 +0,0 @@ -echo cow | read foo -echo "$foo" diff --git a/badcase/subshellvar2 b/badcase/subshellvar2 deleted file mode 100644 index 9c4d0da..0000000 --- a/badcase/subshellvar2 +++ /dev/null @@ -1,7 +0,0 @@ -for f in * -do - echo "Processing: $f" -done | tee log - -echo "Done. Last processed was $f." - diff --git a/badcase/subshellvar3 b/badcase/subshellvar3 deleted file mode 100644 index fcc3553..0000000 --- a/badcase/subshellvar3 +++ /dev/null @@ -1,3 +0,0 @@ -export lol=32 & -wait -echo "$lol" diff --git a/badcase/subshellvar4 b/badcase/subshellvar4 deleted file mode 100644 index 228e754..0000000 --- a/badcase/subshellvar4 +++ /dev/null @@ -1,3 +0,0 @@ -n=0; -mycmd | while read foo; do rm "$foo"; ((n++)); done -echo "Deleted $n files" diff --git a/badcase/superfluousfunction b/badcase/superfluousfunction deleted file mode 100644 index ad54c10..0000000 --- a/badcase/superfluousfunction +++ /dev/null @@ -1 +0,0 @@ -function foo() { echo bar; } diff --git a/badcase/twogreaterandone b/badcase/twogreaterandone deleted file mode 100644 index 1438d22..0000000 --- a/badcase/twogreaterandone +++ /dev/null @@ -1 +0,0 @@ -strace foo 2>&1 > allmessages diff --git a/badcase/unexpanded b/badcase/unexpanded deleted file mode 100644 index 4b74d4a..0000000 --- a/badcase/unexpanded +++ /dev/null @@ -1,2 +0,0 @@ -foo=bar -echo $file | sed -e 's/$foo/baz/g' diff --git a/badcase/unquoteddoubleat b/badcase/unquoteddoubleat deleted file mode 100644 index 64903a1..0000000 --- a/badcase/unquoteddoubleat +++ /dev/null @@ -1 +0,0 @@ -myapp $@ diff --git a/badcase/unquotedexpansion b/badcase/unquotedexpansion deleted file mode 100644 index 3c8ec69..0000000 --- a/badcase/unquotedexpansion +++ /dev/null @@ -1 +0,0 @@ -echo Your locales: $(locale) diff --git a/badcase/unquotedtest b/badcase/unquotedtest deleted file mode 100644 index b0be8cb..0000000 --- a/badcase/unquotedtest +++ /dev/null @@ -1 +0,0 @@ -if [ -f $foo ]; then echo cow; fi diff --git a/badcase/uuoc b/badcase/uuoc deleted file mode 100644 index cab0386..0000000 --- a/badcase/uuoc +++ /dev/null @@ -1 +0,0 @@ -cat foo | grep bar diff --git a/badcase/worseindenting b/badcase/worseindenting deleted file mode 100644 index ef4d43a..0000000 --- a/badcase/worseindenting +++ /dev/null @@ -1,6 +0,0 @@ -if true -then - cat << FOO - Some text - FOO -fi diff --git a/goodcase/double b/goodcase/double deleted file mode 100644 index 854394f..0000000 --- a/goodcase/double +++ /dev/null @@ -1,2 +0,0 @@ -echo hello -echo world diff --git a/goodcase/double2 b/goodcase/double2 deleted file mode 100644 index 7962e5c..0000000 --- a/goodcase/double2 +++ /dev/null @@ -1 +0,0 @@ -echo one; echo two diff --git a/goodcase/forargs b/goodcase/forargs deleted file mode 100644 index a3393bc..0000000 --- a/goodcase/forargs +++ /dev/null @@ -1 +0,0 @@ -for f in "$@"; do echo "$f"; done diff --git a/goodcase/forloop b/goodcase/forloop deleted file mode 100644 index 079348d..0000000 --- a/goodcase/forloop +++ /dev/null @@ -1 +0,0 @@ -for f in *; do echo "$f"; done diff --git a/goodcase/fornoin b/goodcase/fornoin deleted file mode 100644 index 28562bf..0000000 --- a/goodcase/fornoin +++ /dev/null @@ -1 +0,0 @@ -for f; do echo "$f"; done diff --git a/goodcase/heredoc b/goodcase/heredoc deleted file mode 100644 index a664927..0000000 --- a/goodcase/heredoc +++ /dev/null @@ -1,3 +0,0 @@ -cat << FOO -test -FOO diff --git a/goodcase/if b/goodcase/if deleted file mode 100644 index 9779d62..0000000 --- a/goodcase/if +++ /dev/null @@ -1 +0,0 @@ -if true; then echo foo; fi diff --git a/goodcase/ifcommand b/goodcase/ifcommand deleted file mode 100644 index 78ca0b3..0000000 --- a/goodcase/ifcommand +++ /dev/null @@ -1,4 +0,0 @@ -if file foo 2>&1 | grep lol 2> /dev/null -then - echo cow -fi diff --git a/goodcase/iftest b/goodcase/iftest deleted file mode 100644 index 0509fea..0000000 --- a/goodcase/iftest +++ /dev/null @@ -1 +0,0 @@ -if [[ $B == 3 ]]; then echo cow; fi diff --git a/goodcase/redir b/goodcase/redir deleted file mode 100644 index 8a13a43..0000000 --- a/goodcase/redir +++ /dev/null @@ -1 +0,0 @@ -echo cow > file diff --git a/goodcase/redir2 b/goodcase/redir2 deleted file mode 100644 index 94d499c..0000000 --- a/goodcase/redir2 +++ /dev/null @@ -1 +0,0 @@ -echo lol 2> /dev/null diff --git a/goodcase/redir3 b/goodcase/redir3 deleted file mode 100644 index 61a4049..0000000 --- a/goodcase/redir3 +++ /dev/null @@ -1 +0,0 @@ -cmd > /dev/null 2>&1 diff --git a/goodcase/simple b/goodcase/simple deleted file mode 100644 index 2f08be9..0000000 --- a/goodcase/simple +++ /dev/null @@ -1 +0,0 @@ -echo hello diff --git a/goodcase/subshellvar b/goodcase/subshellvar deleted file mode 100644 index f4d7a7b..0000000 --- a/goodcase/subshellvar +++ /dev/null @@ -1,3 +0,0 @@ -( a=3; ) -a=4; -echo "$a"