[Dockerfiles] Used best practices for apt-get

See https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#apt-get

- Replaced `-y install` with `install -y` (unification)

- Put every package on its own line

- Moved `rm -rf /var/lib/apt/lists/*` in the same `RUN` statement as `apt-get`

- Removed unnecessary `apt-get clean`
  See 03e2923e42/contrib/mkimage/debootstrap (L82-L105)
This commit is contained in:
Michael Käufl
2017-05-13 15:52:16 +02:00
parent d0d0961006
commit 9ab9d76240
7 changed files with 40 additions and 28 deletions

View File

@@ -7,8 +7,8 @@ ENV LC_ALL C
ENV DOVECOT_VERSION 2.2.29.1
ENV PIGEONHOLE_VERSION 0.4.18
RUN apt-get update \
&& apt-get -y install libpam-dev \
RUN apt-get update && apt-get -y install \
libpam-dev \
default-libmysqlclient-dev \
lzma-dev \
liblz-dev \
@@ -48,7 +48,8 @@ RUN apt-get update \
libdbd-mysql-perl \
libipc-run-perl \
make \
cpanminus
cpanminus \
&& rm -rf /var/lib/apt/lists/*
RUN wget https://www.dovecot.org/releases/2.2/dovecot-$DOVECOT_VERSION.tar.gz -O - | tar xvz \
@@ -100,8 +101,7 @@ EXPOSE 24 10001
ENTRYPOINT ["/docker-entrypoint.sh"]
CMD exec /usr/bin/supervisord -c /etc/supervisor/supervisord.conf
RUN apt-get clean \
&& rm -rf /var/lib/apt/lists/* \
RUN rm -rf \
/tmp/* \
/var/tmp/* \
/dovecot-2.2-pigeonhole-$PIGEONHOLE_VERSION \