Update ci.py

feat(CiManager.add()): Check the attribute is in the ci_type attributes list
This commit is contained in:
lovvvve 2021-01-28 16:27:56 +08:00 committed by GitHub
parent 97fc5896a5
commit e6d3c34f75
1 changed files with 4 additions and 0 deletions

View File

@ -187,8 +187,12 @@ class CIManager(object):
return abort(404, 'CI <{0}> does not exist'.format(unique_value)) return abort(404, 'CI <{0}> does not exist'.format(unique_value))
ci = CI.create(type_id=ci_type.id) ci = CI.create(type_id=ci_type.id)
ci_type_attrs_name = [attr["name"] for attr in CITypeAttributeManager().get_attributes_by_type_id(ci_type.id)]
value_manager = AttributeValueManager() value_manager = AttributeValueManager()
for p, v in ci_dict.items(): for p, v in ci_dict.items():
if p not in ci_type_attrs_name:
current_app.logger.warning(f'ci_type: {ci_type_name} not has attribute {p}, please check!')
continue
try: try:
value_manager.create_or_update_attr_value(p, v, ci, _no_attribute_policy) value_manager.create_or_update_attr_value(p, v, ci, _no_attribute_policy)
except BadRequest as e: except BadRequest as e: