7x31
/
cmdb
mirror of https://github.com/veops/cmdb.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #77 from x-7/x-7-patch-1 

cmdb-api:add attr check in ci_manager update method
This commit is contained in:
pycook 2021-04-22 09:14:33 +08:00 committed by GitHub
parent 5256f79ba1 7936b9cb09
commit 9c76b388c9
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmdb-api/api/lib/cmdb/ci.py
View File

@ -206,9 +206,13 @@ class CIManager(object):
def update(self, ci_id, **ci_dict): def update(self, ci_id, **ci_dict):
ci = self.confirm_ci_existed(ci_id) ci = self.confirm_ci_existed(ci_id)
ci_type_attrs_name = [attr["name"] for attr in CITypeAttributeManager().get_attributes_by_type_id(ci.type_id)]
value_manager = AttributeValueManager() value_manager = AttributeValueManager()
for p, v in ci_dict.items(): for p, v in ci_dict.items():
if p not in ci_type_attrs_name:
current_app.logger.warning('ci_type: {0} not has attribute {1}, please check!'.format(ci.type_id, p))
continue
try: try:
value_manager.create_or_update_attr_value(p, v, ci) value_manager.create_or_update_attr_value(p, v, ci)
except BadRequest as e: except BadRequest as e: